sleap icon indicating copy to clipboard operation
sleap copied to clipboard

Prioritize user instances when coping from prior frame

Open vaibhavtrip29 opened this issue 1 year ago • 3 comments

Description

Prioritised copy prior frame to take user instance when available.

Types of changes

  • [X] Bugfix
  • [ ] New feature
  • [ ] Refactor / Code style update (no logical changes)
  • [ ] Build / CI changes
  • [ ] Documentation Update
  • [ ] Other (explain)

Does this address any currently open issues?

[list open issues here] https://github.com/talmolab/sleap/issues/1065

Outside contributors checklist

  • [ ] Review the guidelines for contributing to this repository
  • [ ] Read and sign the CLA and add yourself to the authors list
  • [ ] Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • [ ] Add tests that prove your fix is effective or that your feature works
  • [ ] Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

:heart:

Summary by CodeRabbit

  • New Features

    • Improved instance addition by prioritizing user instances over predicted ones when copying from previous frames.
  • Tests

    • Added tests to ensure the new instance prioritization logic works correctly.

vaibhavtrip29 avatar Jan 12 '24 05:01 vaibhavtrip29

Walkthrough

The recent update to the GUI application extended the logic for setting the copy instance to consider the type of instance and prioritize user instances over predicted instances. It introduced new static methods in commands.py to handle the replacement of instances with user instances if needed, and in test_commands.py, it added new test functions and made modifications to existing ones to validate the enhanced functionality.

Changes

File(s) Change Summary
sleap/gui/commands.py Extended logic for setting copy instance, added new static methods.
tests/gui/test_commands.py Added new test functions, modified existing ones.

Poem

🐇 "In the realm of frames and points,
A clever hop to join the joints.
User's touch now leads the dance,
CodeRabbit hails the enhanced stance." 🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot] avatar Jan 12 '24 05:01 coderabbitai[bot]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (60a441f) 73.38% compared to head (8013b77) 73.41%. Report is 1 commits behind head on develop.

:exclamation: Current head 8013b77 differs from pull request most recent head 61be664. Consider uploading reports for the commit 61be664 to get more accurate results

Files Patch % Lines
sleap/gui/commands.py 95.23% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1658      +/-   ##
===========================================
+ Coverage    73.38%   73.41%   +0.03%     
===========================================
  Files          134      134              
  Lines        24064    24083      +19     
===========================================
+ Hits         17659    17681      +22     
+ Misses        6405     6402       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 12 '24 20:01 codecov[bot]

@coderabbitai review

roomrys avatar Jan 12 '24 20:01 roomrys