Maarten S

Results 11 comments of Maarten S

Thanks to the above repro of @jstolp , I've been able to prove that this issue exists for multiple column definitions: - NVARCHAR(MAX) - VARCHAR(MAX) - VARCHAR(4002) or higher. It...

@absci , are you able to look into this? Or can you please provide some time frame? The reproductions are clear and I think it’s a pretty serious issue (will...

It feels like a unrealistic, mixed type use case from the past. I think the proper fix is to remove this example completely, less is more.

@sebastianbergmann Since attributes and the event system have launched, could you maybe consider to evaluate this for v12? I think this is one of the more common pitfalls, and multiple...

@rr-it : One of many other example cleanup scripts: https://github.com/talkinnl/dont-leak , then you only need to add a single line to your BaseTestCase. It'll also cleanup privates, and privates of...

@mvorisek Based on your PR (https://github.com/sebastianbergmann/phpunit/pull/5867 ), I didn't get yet that it really didn't work for you. And the change actually has proven to pay off for huge testsuites...

Yes, you're right. One last time on this closed ticket, as a triaging service :) It's only for this contrived example; The iterator is only destructed after all dataprovider values...

```on: push: branches: - 'main' - 'releases/**' ``` Example syntax to restrict the push workflow. I can make a PR for this. :)

I thought of this: ``` on: pull_request: branches: - main - "[0-9]*" push: schedule: - cron: "15 0 * * *" ``` i.e. add a branch restriction for main or...

Thanks for the reply and the hints. Does sound like a little bit more work than I initially would've guessed, but I want to give it a try as soon...