Valerij Talagayev
Valerij Talagayev
@hmacdope > @talagayev you have the right idea of what to test, and your test implementations are good! > > However to achieve better coverage and to make your tests...
@hmacdope I managed to get the test locally in `_SingleFrameReader` and it covers the cases, but trying to add it into `BaseReaderTest` leads to errors such as: `AttributeError: 'PosixPath' object...
@hmacdope Hey Hugo, I adjusted now the tests and moved them to `base.py` as you suggested. As I mentioned there were the problems with the cases when i applied the...
@hmacdope all good, no worries :)
@hmacdope Hm strange error, I try to find the error going through the pytests and running the developer version of MDAnalysis with this version and can't track down the error...
I checked again which tests would fail if `aux_data` would be set as mandatory, those would be `test_edr.py` and `test_xvg.py` delivering the following error message once in `test_edr.py` and twice...
Quick follow-up on the reason of the errors during `test_edr.py` and twice in `test_xvg.py` if `aux_data` is set as mandatory. The error in them stands from `testsuite/MDAnalysisTests/auxiliary/base.py` that has a...
Should it stay right now as it is, with `aux_data` optional and be changed to mandatory later on in a follow-up PR?
> Given that this PR has to wait for 3.0, it would make sense to implement the complete change to fully address #3811, i.e., make `aux_data` _mandatory_ and `aux_spec` optional....
> Btw, @talagayev please also click the checkbox for Developer Certificate of Origin in the issue. Without it, we will not be able to ever merge the contribution. Done