Takumi Takahashi

Results 7 comments of Takumi Takahashi

Merged Specinfra: https://github.com/mizzy/specinfra/commit/30e1c2177f7b8a2b8e2a8302a8492373480b3641

thank you for your comment. I'm sorry I forgot to add a test case. I think Serverspec needs a new resource type. Add a test case when a new resource...

I created the following pull request: https://github.com/mizzy/specinfra/pull/694 Besides this, I would like to add test cases after the necessary corrections are merged. It takes a long time, I am sorry.

Thank you for the review! I think it would be better to change it for the following reasons. 1. It is more elegant to set the properties of http.Client and...

> In case HTTP request is not completed in 30 minutes, no need to retry, I think. I believe that you should set timeouts for individual connections. Then the download...

I am sorry that the update of PR is late. When I tested launchpad.net mirroring with the following settings, I confirmed that the 30 minute timeout was insufficient. [go-apt-mirror.toml (gist)](https://gist.githubusercontent.com/takumin/157488c5d63cec31f5e195421c9f12b0/raw/006ae153b4c1d8b3533ec3ccaa7354910d69b7a9/go-apt-mirror.toml)...

@nishitaniyuki Tested with the following configuration file: [go-apt-mirror.toml (gist)](https://gist.githubusercontent.com/takumin/157488c5d63cec31f5e195421c9f12b0/raw/9cd0aa7795e8932a5c874454868b7f3c7427cb82/go-apt-mirror.toml) Synchronization has failed with the [previous fix](https://github.com/takumin/aptutil/commit/8ad9924dbce33ba77f044388a6d6b44919b1fc89). [failed.log (gist)](https://gist.githubusercontent.com/takumin/157488c5d63cec31f5e195421c9f12b0/raw/9cd0aa7795e8932a5c874454868b7f3c7427cb82/failed-old-commit.log) Synchronization is successful with the [new fix](https://github.com/takumin/aptutil/commit/d0d85d0df7f2741e607582d92c186b65099e4d95). [success.log (log)](https://gist.githubusercontent.com/takumin/157488c5d63cec31f5e195421c9f12b0/raw/9cd0aa7795e8932a5c874454868b7f3c7427cb82/success-new-commit.log)