李扬
李扬
> Verified on TPC-DS, but some fixes were needed for Velox backend. @taiyang-li Could you give me the access to push to this branch, so I can add them to...
> > Access added, you can push now. > > Thanks for that. But I found I still cannot push to this PR, so I opened one PR to your...
@rui-mo Can you see why velox uts are failed? It is likely related to decimal types.
@rui-mo Thanks for you checking. @zzcclp let's wait for the refine work of @PHILO-HE to be merged
PR in progress: - https://github.com/Kyligence/ClickHouse/pull/128 - https://github.com/oap-project/gluten/pull/402
I'll try to work it out.
https://github.com/Kyligence/ClickHouse/pull/163 close it .
> please rebase to main and add some ut. Sorry, I'am new to gluten, where do you advice to add uts, thanks!
> please refer to [gluten-ut](https://github.com/oap-project/gluten/tree/main/gluten-ut) module or the test cases in https://github.com/oap-project/gluten/tree/main/backends-clickhouse/src/test/scala/io/glutenproject/execution It is done.