Taiki Endo comments

Results 938 comments of


                                            Taiki Endo

Implement valuable-json

Currently, this is almost the same as the JSON serializer example that I previously wrote. Hopefully, I can get the rest of the implementation work done over the weekend and...

Is it possible to allow to visit a value referencing data owned by the current function?

triage: A variant of Value to handle this (Value::Displayable?) can be added later without API break, so there is no need to consider this as a blocker of 0.1.0.

Implement valuable-json

Thanks @KodrAus! That benchmark is very useful. --- It seems that one of the problems is that the `escape` function is not inlined. Inlining the `escape` function would greatly improve...

Consider Visit::visit_key + Visit::visit_value

The initial idea of valuable-serde had ToSerde (Serializable) and FromSerde, and IIRC this was needed when implementing FromSerde. In the end, only ToSerde (Serializable) was implemented, so it was deferred....

Channel `select` panics "passed a receiver that wasn't selected" when using different clones of the same receiver

Currently, we are using a reference to the sender as an identifier, but I guess we can fix this by using the pointer that the sender points to as an...

Make alloc optional (embedded rust)

@nils-van-zuijlen Please read previous comments (https://github.com/tokio-rs/bytes/issues/479#issuecomment-776539743 and https://github.com/tokio-rs/bytes/issues/479#issuecomment-778177512).

Not compatible with Miri's stacked borrow implementation

Closing -- fixed

Avoid spawning the async-io thread if possible

Yeah, both of the currently submitted PRs seem to cause problems with the existing code when the threads are disabled.

Avoid spawning the async-io thread if possible

Yeah, theoretically it would be more efficient to have no threads, but I don't see this as some kind of bug or problem that needs to be fixed in the...