Taiki Endo

Results 938 comments of Taiki Endo

Closing -- We are not affected by this issue.

I believe this is why we see `- (0/0)` in html report. (`- (0/0)` does not look good and confusing, so I need to find a way to get rid...

Yeah, support for passthrough arguments has some bugs: see also https://github.com/taiki-e/cargo-llvm-cov/pull/144#issuecomment-1072750780 and https://github.com/taiki-e/cargo-llvm-cov/pull/144#issuecomment-1072772281 The proposed (and accepted) fix is https://github.com/taiki-e/cargo-llvm-cov/pull/144#issuecomment-1072955602, but has not yet been implemented.

The fix has been published in [0.5.0](https://github.com/taiki-e/cargo-llvm-cov/releases/tag/v0.5.0)

> `cargo-llvm-cov` currently uses `--remap-path-prefix` internally (not sure for the reason why?). IIRC, this was needed because sometimes macros are displayed with absolute paths in HTML reports. https://github.com/taiki-e/cargo-llvm-cov/blob/30efe472911693470cca4a8491ac3abea73ac423/src/main.rs#L205-L206 I guess...

> Are you suggesting the flag might not be necessary after all? Yes

(I'm starting to think to provide an option to disable --remap-path-prefix: https://github.com/taiki-e/cargo-llvm-cov/issues/140#issuecomment-1055457353)

Closing as https://github.com/rust-lang/rust/pull/92648 has been closed. Also, --remap-path-prefix is optional since cargo-llvm-cov 0.3 (https://github.com/taiki-e/cargo-llvm-cov/pull/141), so the problem may no longer be reproducible without the --remap-path-prefix option. Thanks anyway for the...

I would accept a PR to add support for this output format. FWIW, in #77, there was a discussion on another way that works on GitLab.