Tomáš Mráz

Results 1511 comments of Tomáš Mráz

We are sorry for neglecting this. Can you please rebase the PR to the fresh master branch to resolve conflicts?

Please drop the merge commits and instead rebase the patches on top of the fresh master branch.

> I assume that the images in this PR are based on the text files. I would like to see build instructions of how to generate the images, preferably using...

> Personally, I _thoroughly_ dislike this re-alignment. It means that statements end up looking weirdly aligned, all because of a brace at the end of a `case` or `default` line,...

One thing that seems to be missing is to check the allowed frames based on the packet type. I.e., check against this table: https://github.com/openssl/openssl/blob/5f10b1f371469f6ca921337c4d390f05ada6c606/doc/designs/quic-design/tx-packetiser.md#frames In case of Initial packet type...

> I've added pointers to a `OSSL_ACKM` and a `OSSL_QRX` in `QUIC_CONNECTION`, and added `SSL_ctrl()` commands to set them, given a `QUIC_CONNECTION *` passed as an `SSL *`. This allows...

> The other option I see is to make `QUIC_CONNECTION` "internal" (i.e. defined in a include/internal header) instead of so deeply private. But that's a lot more invasive, so I'd...

> Does this make sense also for openssl-3.0? I am not sure this will qualify as pure bug fix so IMO no.

> I am not sure this will qualify as pure bug fix so IMO no. And to make it even stronger changing the return value of functions from void to...

**Summary of what are the things to decide here by OTC:** This PR changes return value of public API calls `X509V3_set_nconf()` and `X509V3_set_ctx()` from `void` to `int`. This is necessary...