Tomáš Mráz comments

Results 1511 comments of


                                            Tomáš Mráz

Improve FIPS RSA keygen performance reduce MR rounds

Could you please do some statistics? I.e., run 20 keygens with and without the patch and compare the times? Possibly for 2 different key sizes to see if the impact...

Improve FIPS RSA keygen performance reduce MR rounds

In general, everywhere where we do random prime generation the 64 MR rounds are way too excessive. The full number of rounds should be used only in case we are...

Improve FIPS RSA keygen performance reduce MR rounds

> I am not sure this is a true measure of anything, since each run is entirely dependent on the random values chosen, > I can see from kachegrind that...

Improve FIPS RSA keygen performance reduce MR rounds

The only difference between these runs is the reduced number of MR rounds? If so, that is much bigger diff than I expected. In that case we should IMO merge...

Fix check for private key existence before eddsa sign functions

I agree, this fix is not necessary for 1.1.1 given this is not really security fix.

Fix check for private key existence before eddsa sign functions

Squashed and reworded commit message. Merged to master, 3.1, and 3.0 branches. Thank you for your contribution.

Update GitHub actions as suggested by dependabot

rebased to resolve conflict after moving the sctp daily job Still OK?

Update GitHub actions as suggested by dependabot

@hlandau ping

Update GitHub actions as suggested by dependabot

Merged to all branches after fixing conflicts as described above. Thank you for the reviews.

QUIC TX Packetiser and Streams Map

CI failures are relevant