Tomáš Mráz comments

Results 1511 comments of


                                            Tomáš Mráz

SSL: `s_client`,`*.pod`: fix documentation on cert_store vs. chain_store/verify_store and PEM format

> Sigh, also here, backporting will require separate PRs due to merge conflicts. This is not just a doc fix. This kind of code changes aren't usually backported.

Horrible `d2i_TYPE*()` reuse behavior leads to crashes on error, e.g., for `ASN1_item_sign_ctx()`

We cannot change the semantics of d2i and I am not sure adding new variants of d2i with different semantics makes much sense.

Fix decoder error on SM2 private key

Could you please add a testcase?

Fix decoder error on SM2 private key

Merged to all the active branches. Thank you for your contribution.

dtls_meth.c: Silently drop records with invalid MAC

**OTC: Is this a bug fix -> should it be backported to all stable branches?**

dtls_meth.c: Silently drop records with invalid MAC

**OTC: This is a bug and eligible for backport to stable branches.**

dtls_meth.c: Silently drop records with invalid MAC

> @t8m is it acceptable to approve this to be run on the CI? Yes, sure, the approval is there just to check there won't be any malicious code run...

dtls_meth.c: Silently drop records with invalid MAC

ping @omerkattan-microsoft could you please rebase this and address my comments above?

The OCSP responder listens only on IPv4

Could you please try the openssl-3.0-beta2 release to check if the problem is still there?

Add support for multiple key shares

> Eg. `!` for key_share (client) and `*` for "worth a HRR" (server). The same group would then look like: > `*!X25519MLKEM678:*SecP256r1MLKEM768:!X25519:P-256 IMO instead of _worth a HRR_ marker you...