Tomáš Mráz comments

Results 1511 comments of


                                            Tomáš Mráz

Add an server example.

@vdukhovni This could be a bug in the library and not the demo server even. I suggest we merge this as is and create a new issue to investigate this.

Add an server example.

Created openssl/project#752 to track the investigation. Merged to the feature branch. Thank you for your contribution.

The issue has been discovered by libFuzzer running on provider target.

So although IMO adding the NULL check to the EVP_DigestUpdate makes sense, we should also fix the KBKDF provider implementation to avoid calling EVP_MAC_update() and EVP_MAC_final() before previous call to...

The issue has been discovered by libFuzzer running on provider target.

> In which case don't we have an update function? In case you call EVP_DigestUpdate on MD_CTX that is just new and not properly initialized with EVP_DigestInit.

The issue has been discovered by libFuzzer running on provider target.

We could have a test for this but it would have to be run only with default provider or skipped if the FIPS version was old.

The issue has been discovered by libFuzzer running on provider target.

> This PR definitely needs a test case We could add one from the oss-fuzz to the fuzz-corpora. I do not think we are running the fuzz tests against the...

The issue has been discovered by libFuzzer running on provider target.

@bernd-edlinger please reconfirm

Check sk_X509_value result before dereference

OK with CLA trivial. @paulidale @hlandau are you OK with CLA: trivial?

Check sk_X509_value result before dereference

Merged to the master branch. Thank you for your contribution.