t-cordonnier

> ``` > // Skip source tuv. > if (tuvSource.lang.equals(tuvTarget2.lang)) { > continue; > } > ``` > > This is basically as same as your idea. > Not exactly:...

> A test case `ExternalTMFactoryTest#testFuzzyMultipleTuv` failed for [deb0b0e](https://github.com/omegat-org/omegat/commit/deb0b0e9dcc7ed8e17f399c5047d96cc70d46045) because expectation is 14 entries includes three EN-US entries but 11 entries. > > and assertion > > ``` > ITMXEntry entry...

Hi Hiroshi Thanks for this info. Now if you look to the pull request you will notice that I divided it into two patches. First one (https://github.com/omegat-org/omegat/pull/234/commits/50cc6a0109a80f8f02b41e4dafff44d98fca7339) works only when...

Also in the code you quoted I saw a potential bug: checking only the length of the target string is not enough - what if the normalization reduces some characters...

No, I do not work on this right now. I had divided my work in two PR, last time, precisely to have the possibility to postpone this second part. First...

Yes, I could reset the clone on my PC and test again. Then I cherry-picked all my patches to a clone of your latest master (revision f661a from 2018-7-17 03:45):...

Sorry for the delay, I was notified only today about your comments. For the moment I corrected only things about style. The rest I will comment tomorrow.

> Can you check the "Allow edits from maintainers" checkbox on the right? Actually it seems to be ckecked. But is it related to commits or comments on Github?

> It seems like you may have missed a couple of my comments I corrected most of the whitespace issues, simply did not give a comment for each of them....

> @t-cordonnier when using ITMXEntry test failed with inconsistency of object types. [02ab2a1](https://github.com/omegat-org/omegat/pull/230/commits/02ab2a1c25f19beca8975e73d3f1f7211c02939d) try to fix it. Yes, ProjectTMX requires really to have TMXEntry because contrarily to TMXWriter2, it makes...