omegat
omegat copied to clipboard
omegat-org
Can read SRX format instead of CONF
SRX format support
After discussion: If CONF file is present and SRX absent, convert it. Next time, OmegaT 4 will use the SRX (while CONF is kept for older versions, but not updated anymore) Rule is valid for global config directory as well as for project-specific segmentation rules.
Last patch adds support for cascade attribute. This was not needed in the past, since you only used SRX for default rules. But now, if a user copies as segmentation.srx a file coming from another tool, this is required for full compatibility.
I rebased your branch onto the latest master to re-trigger the Jenkins check (your parent on master had an error in it, plus the Jenkins job was broken). You'll want to reset your local branch to the remote one. Sorry for the inconvenience.
Yes, I could reset the clone on my PC and test again. Then I cherry-picked all my patches to a clone of your latest master (revision f661a from 2018-7-17 03:45): it seems to work without any problem. I see no changes to do on this topic for the moment: unless you have more comments, now you can execute the pull request.
Sorry for the delay, I was notified only today about your comments. For the moment I corrected only things about style. The rest I will comment tomorrow.
You certainly don't need to apologize for any delays when I am taking forever to get back to you myself.
I have learned a valuable lesson: I shouldn't have left so many comments about formatting. Since you fixed the formatting most of our conversation is buried in "outdated" collapsed chunks. Next time I will mention formatting just once.
It seems like you may have missed a couple of my comments (which is very reasonable as things are horribly buried now). I am happy to take care of them myself, but I can't push to your branch. Can you check the "Allow edits from maintainers" checkbox on the right?
Can you check the "Allow edits from maintainers" checkbox on the right?
Actually it seems to be ckecked. But is it related to commits or comments on Github?
Actually it seems to be ckecked.
Sorry! I must have done something wrong on my end, then. I'll take another look.
But is it related to commits or comments on Github?
The "learn more" link says:
If checked, users with write access to target branch can add new commits to your source branch branch. You can always change this setting later.
Sorry! I must have done something wrong on my end, then. I'll take another look.
This was my own mistake. I managed to push the commits.
It seems like you may have missed a couple of my comments
I corrected most of the whitespace issues, simply did not give a comment for each of them. But reading your corrections, I understand that I also missed the extra whitespaces on empty lines. Thanks for the correction.
Sorry for the long delay on this. Since this is a pretty major change, I'd like to wait until OmegaT 4 has been promoted to "standard" and we can put this in OmegaT 5.
All this is way beyond my understanding, but reading @amake's last comment, it seems that we have a window of opportunity now that 4 is stable is 5 is heading toward stability with the work on the manual undergoing.
@t-cordonnier I understand that this merge is not a priority at the moment, but it would be nice to set a milestone, even a "floating" one. Just to not let it rot. So I'm setting it for 6.1, with the possibility to push it further if needed. Thank you for your work.
