Sandor Szücs

Results 610 comments of Sandor Szücs

/approve /lgtm

@mattn please provide first a test that breaks, which you fix by that change.

We need a test that proofs that it works or we will break it in the future. Also better to add an option to enable this changed behavior and do...

@senghoo, great to read, that you want to do a Go port. We could integrate and build a Go http proxy waf with that. We thought about hacking a bit...

> This is quite a lot of new code and I am concerned about supporting this. > > @szuecs should we also consider > > * adding AWS sdk as...

@Anurag252 I tried to answer all comments that seem to have an open question. If there is something missing please point us to it.

I didn't check but please check the CodeQL warning. I think we should fix it.

From my side looks good, only some godoc related errors