external-dns
external-dns copied to clipboard
kubernetes-sigs
fix: do not check ownerID if the resource does not provide owner labels.
Description
Current implementation always check owner labels eventhough the resource does not provide it. So i don't get succeeded to update A record on cloudflare.
./external-dns \
--resolve-service-load-balancer-hostname \
--source=service \
--source=ingress \
--provider=cloudflare \
--domain-filter=mail.example.com \
--zone-id-filter=XXXXX-MY-CLOUDFLARE-ZONE-ID-XXXXX \
--interval=20s
With this patch, this works fine for me. But currently, this break TestMultiClusterDifferentRecordTypeOwnership since desired does not have owner ID. If it is acceptable to add a flag to omit the owner ID check, I would like to change this PR.
Checklist
- [ ] Unit tests updated
- [ ] End user documentation updated
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @mattn!
It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @mattn. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@mattn please provide first a test that breaks, which you fix by that change.
@szuecs I still don't see how it is practically possible to ignore the ownerID check. So I can't write a test.