Simon Žlender

Results 63 comments of Simon Žlender

Happy to contribute this change if we can make a final decision. It seems the only disagreement is on whether or not to include a fallback nix package? I still...

No worries, makes sense.

This can be fixed with: ``` diff --git a/src/libstore/build/sandbox-defaults.sb b/src/libstore/build/sandbox-defaults.sb index 25ec11285..2ad5fb616 100644 --- a/src/libstore/build/sandbox-defaults.sb +++ b/src/libstore/build/sandbox-defaults.sb @@ -45,7 +45,7 @@ R""( ; allow it if the package explicitly asks...

Another thing we could do is make the package runnable by including a `bin/$pname` script in the test derivation that returns with the exit code of `cargo test`/`cargo nextest`. Maybe...

Conceivably you could `removeReferencesTo` everything in `nativeBuildInputs -- buildInputs`. It would be nice if it could be done in a single pass as vendored deps, as doing this over and...

Yeah, just on resulting binaries I think. But `removeReferencesTo` can only remove a single reference, so if you wanna get rid of all `nativeBuildInputs` (plus probably propagated ones), it will...

Yeah I definitely agree that crane shouldn't do anything here by default. My thinking was that we could extend the removeVendoredSources functionality to remove other manually specified references as well....

I ran into the same issue. It works fine with a cargo build outside of Nix. But inside Nix the transient dependency's registry is never referenced in the crane generated...

@ipetkov I prepared a repro case over at https://github.com/szlend/crane-reg-test The `cargo build` in the devshell works fine, but `nix build` fails when the `cargo check` tries to fetch crates from...