zed icon indicating copy to clipboard operation
zed copied to clipboard

Add Nickel syntax highlighting

Open szlend opened this issue 1 year ago • 6 comments

Release Notes:

  • Added Nickel syntax highlighting

szlend avatar Jan 29 '24 20:01 szlend

We require contributors to sign our Contributor License Agreement, and we don't have @szlend on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Jan 29 '24 20:01 cla-bot[bot]

We require contributors to sign our Contributor License Agreement, and we don't have @szlend on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

cla-bot[bot] avatar Jan 29 '24 20:01 cla-bot[bot]

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jan 29 '24 20:01 cla-bot[bot]

@cla-bot check

szlend avatar Jan 29 '24 20:01 szlend

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar Jan 29 '24 20:01 cla-bot[bot]

Please also add a new docs entry to the https://github.com/zed-industries/zed/tree/main/docs/src/languages list

SomeoneToIgnore avatar Jan 29 '24 20:01 SomeoneToIgnore

@szlend Thanks for the PR. I think that for right now, we need to limit how many languages we bundle into Zed because of compile time issues. Because Nickel is a bit more obscure of a language, I'd like to hold off on adding it, for the sake of our app's build time.

We are actively working on the ability for Zed to load arbitrary Tree-sitter parsers via Wasm files. It is one of my top priorities at the moment. Once that happens, we'll be able to have a Nickel plugin, and we plan to automatically surface available plugins when users are editing unsupported file extensions. You'll be able to package the exact code that you wrote here into an extension.

Here is a tracking issue for our support of language extensions: https://github.com/zed-industries/zed/issues/7096.

maxbrunsfeld avatar Jan 30 '24 17:01 maxbrunsfeld

No worries, makes sense.

szlend avatar Jan 30 '24 18:01 szlend