Shing Hei Zhan

Results 23 comments of Shing Hei Zhan

@ababaian mentioned that no one has been tackling this, so I'mma make an attempt if you guys don't mind!

Notes about interpretation of IQS: 1. "The value of one indicates a perfect match" (from the IQS paper); 2. The value of zero indicates that the observed agreement is equal...

Should it be implemented as ``TreeSequence.wattersons_theta()``? ``` def wattersons_theta(self): return(self.segregating_sites() / np.sum([1/i for i in np.arange(1, self.num_samples)])) ```

Should there be additional arguments ``sample_sets=None`` and ``windows=None`` like ``TreeSequence.diversity()``?

I think that the tests for `ts.Wattersons_theta()` should be similar to the tests implemented for `ts.segregating_sites()` or another statistic that has the site, node, and branch modes.

@benjeffery has suggested doing the following tasks (as separate PRs) to solve this issue. ~0 - Add ts.genotype_matrix to performance benchmark - PR 1~ ~1 - Change current implementation to...

As agreed in #2494 we will revisit adding `sites` argument at some time.

Is this feature still desired?

Hi @Emaasit ! This is a very cool project! Is it too late to contribute?

Shouldn't the probability of match and probability of mismatch sum to 1? If that is the case, then I suspect there is a bug. In this code snippet: ``` p_e...