Andrés Taylor

Results 53 comments of Andrés Taylor
trafficstars

Hi @ABlueCy! Are you still interested in merging this PR? I'm going over old PRs checking what we can close.

I added @deepthi to the reviewers. This change will affect a lot of users, so it's probably a good idea to get her input on it

Hi @MengJianGui! Are you still interested in merging this PR? I'm going over old PRs checking what we can close.

Hi @Abirdcfly! Thanks so much for your contribution. We are moving most of the test code to use https://github.com/stretchr/testify instead of t.Error and t.Fatal. No chance you could update these...

Hi @FanChenyu! Are you still interested in getting this merged? I'm going over old PRs checking what we can close.

Hi @Jin-2019! Are you still interested in merging this PR? I'm going over old PRs checking what we can close.

> does this mean we will start failing queries for group by/ having if the schema tracking is not enabled? your comment was not connected to anything I could see,...

just to circle back the discussion we've been having on slack here seems like the codecov is not reporting these numbers accurately. according to [this report](https://app.codecov.io/gh/vitessio/vitess/tree/main), the coverage for some...

so, checking out the changes, it looks like we're waiting around to get all the input types before we figure out how to coerce the values properly. but really, we...

> Once RC1 is published, we accept bug reports against that and evaluate whether they should be fixed. If we fix a bug, we publish another release candidate. Would we...