fix minor code unreachability error

[Abirdcfly]

Signed-off-by: Abirdcfly [email protected]

Description

Related Issue(s)

Fixes #10772

Checklist

• [x] "Backport me!" label has been added if this change should be backported
• [x] Tests were added or are not required
• [x] Documentation was added or is not required

Deployment Notes

[vitess-bot[bot]]

Review Checklist

Hello reviewers! :wave: Please follow this checklist when reviewing this Pull Request.

General

• [ ] Ensure that the Pull Request has a descriptive title.
• [ ] If this is a change that users need to know about, please apply the release notes (needs details) label so that merging is blocked unless the summary release notes document is included.
• [ ] If a new flag is being introduced, review whether it is really needed. The flag names should be clear and intuitive (as far as possible), and the flag's help should be descriptive. Additionally, flag names should use dashes (-) as word separators rather than underscores (_).
• [ ] If a workflow is added or modified, each items in Jobs should be named in order to mark it as required. If the workflow should be required, the GitHub Admin should be notified.

Bug fixes

• [ ] There should be at least one unit or end-to-end test.
• [ ] The Pull Request description should either include a link to an issue that describes the bug OR an actual description of the bug and how to reproduce, along with a description of the fix.

Non-trivial changes

• [ ] There should be some code comments as to why things are implemented the way they are.

New/Existing features

• [ ] Should be documented, either by modifying the existing documentation or creating new documentation.
• [ ] New features should have a link to a feature request issue or an RFC that documents the use cases, corner cases and test cases.

Backward compatibility

• [ ] Protobuf changes should be wire-compatible.
• [ ] Changes to _vt tables and RPCs need to be backward compatible.
• [ ] vtctl command output order should be stable and awk-able.

[Abirdcfly]

This commit should be able to backport to an older version, but I'm not sure if it's necessary.

[systay]

Hi @Abirdcfly!

Thanks so much for your contribution.

We are moving most of the test code to use https://github.com/stretchr/testify instead of t.Error and t.Fatal. No chance you could update these tests to use that instead of just moving the Fatals around, is there?

Instead of:

tree, err := ParseNext(tokens)
if err != nil {
	t.Fatalf("[%d] ParseNext(%q) err: %q, want nil", i, input, err)
	continue
}

we now prefer:

tree, err := ParseNext(tokens)
require.NoError(t, err)