Deltadroid

Results 100 comments of Deltadroid

Oh, I see now that slf4j and additional proguard rules are required for minify. Sorry about that.. WARNING:R8: Missing class org.slf4j.impl.StaticLoggerBinder Now i see why you added them ;-)

is `crunchPngs true` also something we want?

Also, since the resources become obfuscated by R8, maybe ` jniDebuggable false` is also appropriate for this.

@bitmold When I started testing this on the master branch, I ran into an error because of AGP 8. This is what I did to solve the issue: https://github.com/syphyr/orbot/commit/7ec449f9edd7ab4319394014e936fb02aa32497b

Minify is causing a bug with retrofit2 by renaming the classes. This causes a fatal exception when selecting the "Ask Tor" feature. I have tried to fix this issue by...

One suggestion on fixing the retrofit2 issue was to add Keep annotations, but that seems to also not be working. ``` --- a/app/src/main/java/org/torproject/android/circumvention/CircumventionApi.kt +++ b/app/src/main/java/org/torproject/android/circumvention/CircumventionApi.kt @@ -12,10 +12,11 @@ import...

Using the @Keep annotations seems like the easiest approach. Here is some further info that seems useful: https://stackoverflow.com/questions/6548213/how-to-keep-classes-containing-specific-members

When updating tor, it would also be a good time to switch over to openssl 3.0 lts branch. The current version of openssl being used has not received any security...

Updating to IPtProxy 3.2.1 might fix this. https://github.com/syphyr/orbot/commit/2daa11a3623157987930b434ce7995884f6fcde1 https://github.com/syphyr/orbot/commit/1298186aa17f140cd8bf35ee35018ae44db86424

Reverting this fixes the issue https://github.com/guardianproject/orbot/commit/bcc84465cba90779eb087eb431eec478717e7aba