Denis Cornehl

Results 253 comments of Denis Cornehl
trafficstars

> Is this the expected behaviour? in general yes. `custom_cache_key_element` was added as a trick to reset the cache, not to handle multiple virtual environments. Also this action was built...

ah, now I understand. Then, #156 would probably solve the problem for you, and/or probably supporting to define the virtualenv directory with `with: virtualenv_dir` or something like that. I'm happy...

@delicb I could see arguments for both ways. > @syphar Would you consider deleting the existing environment before restoring cache content? Maybe make it configurable with an input? while this...

@Nemo157 @GuillaumeGomez I'm not sure I fully follow, is anything missing here? Or is this ready to be merged? Generally you two can merge too :)

So, while it's true that we now get much less traffic on this endpoint, it's not zero. I'm not sure if we now still should remove this endpoint, where it...

I had a chat with Tobias (crates.io) who in the end have a similar issue (private APIs that are publicly used). To get more info I created https://github.com/rust-lang/simpleinfra/pull/354 to be...

- the respective handler is `web::source::source_browser_handler` - using `templates/crate/source.html` as template.

this is awesome, thank you for the help! will look at the PR

mentoring instructions: - when loading the crate details from the database (in `CrateDetails::new` in `web::crate_details`) we also load `documentation_url` - here we want to _ignore_ the documentation URL when it...

Hi, thank you for the idea! Could you elaborate on how you imagine this to look like? How would we know _which_ features to add here? Where do you see...