Denis Cornehl

Results 210 comments of Denis Cornehl

we actually used `requests_mock` to mock the actual HTTP requests that this library does to SF.

@robertmrk what would be the way forward here? I admit I don't know asyncio in that much detail, but I assume that the `loop` parameter is just not _needed_ any...

> > > I didn't find tests covering this part of the codebase, I'm happy to add them with a better idea on what should be covered and how. >...

> > I didn't find tests covering this part of the codebase, I'm happy to add them with a better idea on what should be covered and how. > >...

> How are relative future dates printed? > `lsd` prints "in ****" for future dates, in contrast to "**** ago" for past dates. Currently it would print _just now_, also...

> > omit the repetitive " ago" > > Note that `timeago` crate has special simplified function [`format_5chars`](https://docs.rs/timeago/latest/timeago/fn.format_5chars.html) for compressed time intervals representations of predictable width. This one is English-only...

> > @ariasuni I added tests as described. Many other tests were failing on my machine, is that intended? > > Uh yeah since they’re not on the CI, there...

@ariasuni is there anything else missing? I'm happy to change where necessary :)