Shohei YOSHIDA

Results 212 comments of Shohei YOSHIDA

IMHO I suppose markdown-mode should not define flyspell/ispell configuration like `markdown-flyspell-check-word-p`, because we may typo in URL, code block, comment. Almost all of other major-modes do not set flyspell/ispell configuration....

- https://github.com/cosmicexplorer/markdown-mode/blob/feat/live-preview-async-timer/tests/markdown-test.el#L3293 - https://github.com/cosmicexplorer/markdown-mode/blob/feat/live-preview-async-timer/tests/markdown-test.el#L3327 I suppose above lines should also check `(fboundp 'libxml-parse-html-region)` for testing eww tests only on Emacs where has libxml2 features.

I suppose tests on Emacs 24.5 are failed by network issue. So they may be passed by rerunning tests. You can rerun tests by some commit and push(For example, squashing...

Could you separate this PR(lexical binding, live preview feature etc) after #95(Some part of this change conflict with #95) ?

> Is that what you're looking for ? Yes. I missed that closed PR. This PR implements multiple features, enabling lexical-binding and live preview. It is difficult to review big...

> The 24.3 case did seem to work, so it's possible that ran on another server? Emacs 24.3 does not have eww. So those tests are not executed on Emacs...

@kprav33n @nickpascucci @brandonw I confirmed `whitespace-mode` problem. But I don't understand `linum-mode` problem. Please show us minimum configuration for reproducing this issue and tell us how to reproduce this issue....

Sorry too late reply. There is no way to capture key now. But you can archive it by hook of `git-messenger` and `global-map` as below. ``` lisp (defvar my/git-messenger-last-message nil)...