Mate Szalay-Beko

Results 37 comments of Mate Szalay-Beko

on 3.6+, zkpython can be built without building zookeeper-server or zookeeper-client using ant. This was fixed in ZOOKEEPER-3567 (which can not be backported to branch-3.5, as we have no SSL...

@eolivelli , @anmolnar , @nkalmar can you take a look?

thanks for the review, merging it now to branch-3.5

I saw a single (most probably unrelated test failure) in the "continuous-integration/jenkins/pr-merge" job ``` FollowerResyncConcurrencyTest.testFollowerWatcherResync:679 Unable to connect to server ``` I retriggered.

> Seems that travis is [not enabled](https://github.com/apache/zookeeper/blob/branch-3.6/.travis.yml) for branch 3.6 ? yeah, it looks the case... we should fix this. although I don't think it would block this PR.

I tried to re-trigger CI. Seems to be some JAVA_HOME setup issue on the CI server?

Not related to this PR necessarily, but it would be nice to come up with some simple reproducible perf test later. Especially because this is part of a larger refactoring...

CI still fails with the same java environment problem. I wonder if it affects also other PRs. Could maybe a rebase help here?

cool, thanks @tisonkun ! @eolivelli - do you think it is OK if I go ahead and merge this? Having travis fix mixed up with the refactoring might not be...

merged to the master branch. Thank you @tisonkun for your contribution!