zookeeper icon indicating copy to clipboard operation
zookeeper copied to clipboard

ZOOKEEPER-4544: sync ant and maven dependencies on branch-3.5

Open symat opened this issue 2 years ago • 3 comments

Our default build system is maven on branch-3.5. However, ant is still supported (and in some cases, like zkpython, one can not even build on branch-3.5 unless we built zookeeper-server with ant before).

Currently if one builds ZooKeeper with ant, she/he will end up having different dependency versions compared to maven (including log4j instead of reload4j).

After this patch, if one executs the following commands:

git clean -xdf
ant clean compile compile-native
cd zookeeper-contrib/zookeeper-contrib-zkpython/
ant compile
ant test

then:

  • zkpython built / tested successfully
  • the zookeeper server related 3pp libs in build/libs folder are up-to-date and should not contain CVEs
  • reload4j jar file is present in build/libs/ instead of log4j

symat avatar May 18 '22 12:05 symat

on 3.6+, zkpython can be built without building zookeeper-server or zookeeper-client using ant. This was fixed in ZOOKEEPER-3567 (which can not be backported to branch-3.5, as we have no SSL support in zookeeper-client-c there)

symat avatar May 18 '22 12:05 symat

@eolivelli , @anmolnar , @nkalmar can you take a look?

symat avatar May 18 '22 12:05 symat

thanks for the review, merging it now to branch-3.5

symat avatar May 18 '22 13:05 symat