Sylvain Leclerc

We should replace the use of plain enums with enum classes. Also, enum type should be used everywhere it's relevant instead of plain `int`, see methods such as: https://github.com/AntaresSimulatorTeam/Antares_Simulator/blob/96832a3a7f75534b5cb68ab7f62421a729acfb51/src/solver/variable/surveyresults/surveyresults.h#L86 **Edit**...

**Description** Adding unit tests involves a few instructions which need to be repeated for each test. They are sometimes forgotten, leading to mistakes, see for example #1744 . ```cmake add_executable()...

**Description** Currently, configuring the project requires to define a special variable `DEPS_INSTALL_DIR` to define where antares-deps was installed. This is not needed and not standard, we should rely instead on...

Random failures in windows CI in adequacy patch tests

1

**Description** From time to time, some adequacy patch tests fail on windows CI, due to differences in results compared to reference. We should investigate where those instabilities could come from....

**Description** Some unit tests would benefit from using a mocking library, instead of hand-written mocks. In particular, the UT introduced in pull request https://github.com/AntaresSimulatorTeam/Antares_Simulator/pull/1716 would be written more easily with...

Spinning reserve: input data should be immutable

2

**Description** See https://github.com/AntaresSimulatorTeam/Antares_Simulator/pull/1661#pullrequestreview-1650660261. To take into account the spinning reserve, we change in place the input timeseries in thermal clusters (`calculationOfSpinning()`), at the start of the computation. We then reverse...