Sylvain Leclerc

Results 52 comments of Sylvain Leclerc

> Consequently, it forces the sensitivity analysis implementation to be based on the bus/view. Not really, it just forces the implementation to map its results on the bus view. But...

Agreed, actually I think that we should not expose only "views" in the API, but also the underlying structure, to make expectations on each topology kind more clear. It means,...

> * the ids are generated, so implementing the uniqueness constraint is hard when you want nice ids (especially when the network is only partially loaded, e.g. network-store) Actually is...

> For the busview, it's always calculatedbus so we we could change the return type de calculated bus Not sure it's a good idea: we could imagine later to have...

Ah yes, I missed the risk of conflict with other types of network elements, thanks for the clarification

I think this information could go into loadflow and security analysis results, like other information about regulations. If we do it in the network: - it's just a "shortcut" method,...

What is TCSC? :) Maybe we should make the name more explicit (or javadoc may be enough).

Note that there was already some discussion 1 year ago about the moving of logs inside `SecurityAnalysisResult`, for ex. here: https://github.com/powsybl/powsybl-core/pull/1585#discussion_r553945200. We should probably discuss it again, but at the...

**Entry point** Indeed we should add an argument to the run method of security analysis providers, something like: ```java interface SecurityAnalysisProvider { CompletableFuture run(...., List scenarios); } ``` **Modelling principles**...

So we have agreed on the following things, mainly going into the simplification direction: - No remedial action simulation on N situation, for now, only post contingency actions - Only...