Sylvestre Ledru
Sylvestre Ledru
LGTM, thanks
Clippy is unhappy: ``` error: useless conversion to the same type: `usize` --> src/uu/more/src/more.rs:472:29 | 472 | .saturating_add(self.content_rows.into()) | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.content_rows` | = help: for further...
note that we have been focusing on compatibility, not perf or memory usage for now (even if some programs are already doing better than GNU's)
well done!
ah fun, exactly what I was working on yesterday. :) you will make life significantly easier
i think it complexifies the code a bit too much for my taste
what would you log ?
yeah, i am not convinced. in general, gdb is doing great work. example: rust-gdb --args ./target/debug/coreutils cksum --binary --tag --untagged -a md5 (doesn't help with the CI)
> Congrats! The gnu test tests/cksum/sm3sum is no longer failing! nice :)
> The code would now falsely claim that files verify with their checksum, without ever actually checking the checksum I am planning to implement it next :)