coreutils icon indicating copy to clipboard operation
coreutils copied to clipboard

Published 20 hours ago • verified publisher icon uutils

ls: fix quoting alignment, add tests for default quoting style in TTY and quoting alignment

Open RenjiSann opened this issue 9 months ago • 6 comments

Fixes #6386

RenjiSann avatar May 14 '24 18:05 RenjiSann

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar May 14 '24 19:05 github-actions[bot]

I guess you saw that some jobs are failing

sylvestre avatar May 14 '24 20:05 sylvestre

I guess you saw that some jobs are failing

Yes, sorry for that. I always forget about linting and windows stuff.

RenjiSann avatar May 14 '24 20:05 RenjiSann

GNU testsuite comparison:

Skip an intermittent issue tests/tail/inotify-dir-recreate (fails in this run but passes in the 'main' branch)

github-actions[bot] avatar May 14 '24 20:05 github-actions[bot]

Forgot to add #[cfg(unix)] on all TTY tests.

RenjiSann avatar May 15 '24 08:05 RenjiSann

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

github-actions[bot] avatar May 15 '24 08:05 github-actions[bot]

@sylvestre if you don't mind taking look. I don't understand why is the macos test failing.

RenjiSann avatar May 16 '24 07:05 RenjiSann

@RenjiSann it isn't your fault. it is unrelated

sylvestre avatar May 16 '24 07:05 sylvestre

LGTM, thanks

sylvestre avatar May 16 '24 07:05 sylvestre