Charles Milette

Results 689 comments of Charles Milette

The problem is specifically in regards to things that aren't a pseudo handle though. Currently this is blocked on the fact that Detours needs to target Windows XP (GetThreadId was...

I'd be ok with that but this effectively requires people to edit the nmake file, which means in most (all?) cases it won't be used. I personally fixed the issue...

`CreateToolhelp32Snapshot` is fine, I was doing this in a `DllMain` so any new thread would have been blocked from running by the loader lock.

I updated the code to dynamically try loading it now.

I've built Detours with `/CETCOMPAT /guard:ehcont` fine, and it runs successfully on both non-CET compatible and CET-compatible hardware. Seems to work fine, for my uses (detouring a function in `user32.dll`)....

Isn't it just possible to use the `diff` syntax highlighting scheme? Eg: ```diff @@ -52,17 +52,6 @@ struct WINCOMPATTRDATA // Unchanged code - // Deleted line + // Added line...

Is Japanese text input even supported on terminal emulators? The Japanese characters being wider than a regular monospaced font, won't that mess up the terminal? Le jeu. 27 juil. 2017...

Yeah, it's just a regular string search. What I was wondering is if you could even enter Japanese characters in the terminal correctly. It messes up enough when I try...