CodeHub icon indicating copy to clipboard operation
CodeHub copied to clipboard

No colors on diff viewer

Open sylveon opened this issue 6 years ago • 4 comments

image

sylveon avatar Oct 29 '17 01:10 sylveon

@aalok05 Since that's basically a chunk of source code anyways, can't you just use the same API we're already using to get the syntax highlight HTML to display when opening a code file?

Sergio0694 avatar Oct 29 '17 09:10 Sergio0694

That's a good idea, however some logic has to be written to color the lines starting with + or -

aalok05 avatar Oct 30 '17 02:10 aalok05

Isn't it just possible to use the diff syntax highlighting scheme? Eg:

@@ -52,17 +52,6 @@ struct WINCOMPATTRDATA
// Unchanged code
- // Deleted line
+ // Added line

sylveon avatar Oct 30 '17 02:10 sylveon

@sylveon This scheme is not yet supported in MarkdownTextblock of UWP community toolkit, which is what we are using. We'll have to create a custom control for this.

aalok05 avatar Oct 30 '17 05:10 aalok05