Sylvain Rabot

Results 140 comments of Sylvain Rabot

> this info should be on the readme Absolutely, the README should explain what are the least scopes needed for an Oauth Client.

Hey @marctc 👋 Are you able to move forward with this, it is something I am greatly looking forward! Thank you!

@codesome any chance you could review the latest changes ? Thank you.

That's a blatant privacy issue, please disable it by default.

I don't know. Personally, I don't think waiting to upgrade dependencies is a good practice as you pile up potential breakages.

FYI perfectly readable rule in configuration ``` ( kube_job_status_failed > 0 UNLESS kube_job_status_succeeded > 0 ) * on (namespace, job_name) group_left(maintainer) label_replace(kube_job_labels, "maintainer", "$1", "label_maintainer", "(.*)") * on (namespace, job_name)...

@geekodour Yes, I mixed up two rules.

> https://prometheus.io/docs/practices/rules/ uses the best practices. Please don't enforce: ``` sum without (instance)(instance_path:requests:rate5m{job="myjob"}) ``` over ``` sum(instance_path:requests:rate5m{job="myjob"}) without (instance) ```