Sylvain Rabot

Results 140 comments of Sylvain Rabot

I do a lot of `git log --oneline --graph` and not having tags makes it hard to know where you at.

I believe you can: ```shell s.rabot@wmbpro-srabot:~/go/src/github.com/thanos-io/thanos [master+tags]$ git reset --hard origin/master 14:07:02 HEAD is now at 43f659a8 Fix invalid start/end params in series api (#2015) s.rabot@wmbpro-srabot:~/go/src/github.com/thanos-io/thanos [master+tags]$ git merge --strategy=ours...

For those interested I've built a docker image with this PR: source: https://github.com/sylr/external-dns/commits/v0.12.0%2Bsylr image: ghcr.io/sylr/external-dns:v0.12.0-2-gca826a18 In my case I had to remove the TXT record and A record of the...

New custom build with this patch source: https://github.com/sylr/external-dns/commits/v0.12%2Bsylr image: ghcr.io/sylr/external-dns:v0.12.2-3-g264cde1a

/remove-lifecycle stale

> Can you assume a role using this? > > > > https://github.com/vmware-tanzu/velero-plugin-for-aws/pull/92 > > > > And if you can, what is the distinction between the two? Sorry, this...

Ran into this issue as well.

Maybe add a concurrent benchmark ? ```go func BenchmarkRecordConcurrently(b *testing.B) { b.ReportAllocs() rr, err := NewRTMetrics(RTClock(testutils.GetClock())) require.NoError(b, err) // warm up metrics. Adding a new code can do allocations, but...

@Raffo @seanmalloy @njuettner I've been running this patch for 6 months now, can we merge it please ?