Sylvain Brunerie comments

Results 25 comments of


                                            Sylvain Brunerie

The elm-package example source links are outdated (404)

The examples that were moved can be found here: https://github.com/w0rm/elm-physics/tree/main/sandbox/src

Add a maintainer page, listing all packages maintained/owned by someone

@rlefevre Looks great!

Urls with . in them are assumed to be files

What about something like checking that the last part of the path contains a single dot, followed by something that looks like an extension (like `[^.]+\.[a-b][a-b0-9]{1,3}`). That would definitely get...

Consider not depending on PHP Sockets extension

It looks like some of these lines (the `socket_strerror` and `socket_last_error` ones) were present as well in branch 2.0, but never caused an issue for me, even if the functions...

Consider not depending on PHP Sockets extension

The issue may actually still be relevant now, because from time to time a connexion causes an error and the websocket server crashes because of `socket_strerror` being undefined. Not sure...

Provide a default prefix to `compile` in `sqlStatement`

I wasn’t able to run the test suite, but it seems like the CI setup itself is broken, so I guess it’s alright. Plus it’s really a small and safe...

Provide a default prefix to `compile` in `sqlStatement`

Should we re-run the checks for this PR? I think the CI setup was kind of broken at the time.

Provide a default prefix to `compile` in `sqlStatement`

@SerafimArts Done!

Provide a default prefix to `compile` in `sqlStatement`

So the test suite fails under MySQL 5.7 but apparently the same test was already failing.

Value incorrectly inferred as falsy, weird interference with other variables

Sorry I didn’t manage to minimize the example further. That’s because, as I mentioned, each of these little blocks before the nested ifs seem to have an effect on the...