Simon Holloway

Results 18 comments of Simon Holloway
trafficstars

I had the same issue as OP, I ended up with: ``` SECRET="$(echo "https://gcr.io" | docker-credential-gcr get | jq '.Secret')" docker login -u _token -p "${SECRET}" https://gcr.io function docker-compose() {...

Due to the fact that the unload lifecycle event handler does not await promises, using the async streams API is very risky as the last flush on unload would not...

SWC make's this hard to do without breaking current functionality. The spy in its current form needs to be a function, so you can use it like this: ```ts import...

I'm just talking about the return value of `spy()`, thats `mySpy` in the example above. `spy` itself will always be a function. You could make that return value be a...

As you start working on the async matchers, you might end up fixing https://github.com/denoland/deno_std/issues/3947 as a side effect.

Is the datetime module deprecated? because https://github.com/denoland/deno_std/pull/3615 suggests that it is.

I'm having a go at this. It looks like moving to the Streams API causes some of the handler methods to become async, this might introduce complexities around what happens...

Is there a way to make the linter enforce this?

Would it be worth using the bdd.ts describe blocks to define the subject under test? ```ts Deno.test({ name: "[std/datetime] isLeap", fn() { assert(isLeap(1992)); assert(isLeap(2000)); assert(!isLeap(2003)); assert(!isLeap(2007)); assert(!isLeap(new Date("1970-01-02"))); assert(isLeap(new Date("1972-01-02")));...

I'm a +1 on this from a philosophical standpoint. The following comment just talks about the justification for middleware in deno_std and nothing about its design. ### The state of...