Sebastiaan Haffert

I agree that we should not have full instrument models because maintaining them is a lot of work and not really what we should be doing. I do think that...

How do you want to compensate tip/tilt ? Do you just want to have tip/tilt compensated wavefronts? Or do you want to simulate a control system with a specific controller?

What have you gotten to work up to now? I guess you could start with tutorial on how to create a broadband PSF. And then you apply the 'subsample_field' function...

The Roman and JWST pupils are defined in the webbPSF package. We could use the same approach as they are doing?

Do we want a 'global' dictionary in the realistic aperture file with the definitions of pupil diameter etc..? Some people might not know the actual diameters and it would be...

I can add the Keck aperture after the new aperture PRs (#140 and #141) are merged. I found the pupil definition on the Keck AO wiki pages: https://www.oir.caltech.edu/twiki_oir/pub/Keck/NGAO/NotesKeckPSF/KeckPupil_Notes.png

I think your attachment did not come through. Is it the ssh key thing that blocks your access?

To circumvent this issue we can switch to the recurrence relation of T. Andersen 2018 (https://www.osapublishing.org/oe/fulltext.cfm?uri=oe-26-15-18878&id=395240) The new recurrence relation does not include 1/r^2 terms because it starts at lowest...

We can probable make a separate class that is called MultiScalePhaseMaskCoronagraph or something like that. The purpose of this class is to do the multiscale propagation that the Vortex uses....

I will be able to work on it next week. This will need to have some additional tests and validation work if I am going to add it in a...