syeopite

Results 197 comments of syeopite

This is an valid feature request that really shouldn't be closed.

Is this really an issue? I personally feel like it looks much cleaner without the underline. Hover being broken on the footer is much more of a problem imo.

The `x-youtube-client-version` header would also have to be set to `6.20180913`

Yep. However, Invidious appends those headers by default as seen in here: https://github.com/iv-org/invidious/blob/993d731c92f6f07e4bee4a222c02e1e47d7f9d6e/src/invidious/helpers/utils.cr#L4-L17 In order to get this fix to work, `x-youtube-client-version` would also have to be set to `6.20180913`

Nope. If we want to use the connection pool, all of those headers would get added no matter what. The only workaround for this is to set `x-youtube-client-version` to `6.20180913`...

> https://github.com/yt-dlp/yt-dlp/pull/328#issuecomment-864117168 `Cr381pDsSsA` is one that still doesn't play even after #2205

Unfortunately Invidious is programmed in Crystal so a php library won't be compatible. Fortunately there are libraries for this and I'll be working on implementing it very soon!

I'm aware. I'm currently just waiting for the maintainer to officially support Crystal 1.0 but I'll go ahead and fork it if needed.