invidious icon indicating copy to clipboard operation
invidious copied to clipboard

[Enhancement] Switch to innertube for the captions - captions do not work on public instances

Open unixfox opened this issue 3 years ago • 8 comments

Is your enhancement request related to a problem? Please describe. The current way of retrieving the captions is rate limited by google and captions doesn't work on popular instances.

Describe the solution you'd like We should switch to the innertube for retrieving the captions because on innertube there is no rate limit (for the moment).

Describe alternatives you've considered

Install and use Invidious locally or switch to a less popular instances from https://instances.invidious.io

Additional context Related to https://github.com/iv-org/invidious/pull/2519 and https://github.com/iv-org/invidious/issues/2565

unixfox avatar Nov 06 '21 22:11 unixfox

Possible solution #2564

syeopite avatar Nov 17 '21 11:11 syeopite

A 20$ bounty has been added to this issue.

Anyone opening a PR fixing this issue, will receive 20$ (in BTC) from the Invidious project.

More details: #1898

TheFrenchGhosty avatar Nov 17 '21 21:11 TheFrenchGhosty

I can personally offer $80 worth of XMR on top of the $20 worth of BTC from the Invidious project, to be claimed by whoever opens a PR switching to innertube for captions to work.

Please ping me here, or via Matrix should there be any news or comments; will try to keep an eye open regardless.

rottenwheel avatar Feb 13 '22 19:02 rottenwheel

About https://github.com/iv-org/invidious/blob/master/src/invidious/routes/api/v1/videos.cr#L34

timedtext API does now provide links for auto-generated captions. Could this replace the current implement of getting the captions?

unixfox avatar Sep 17 '22 14:09 unixfox

How does newpipe does it? Is it because it does it directly so it's not rate limited at the expense of a risk of user tracking?

Due to the elapsed time, is this less work-demanding solution worth considering as an alternative? : if proxy is disabled, then do the request for subtitles directly from user's browser.

tuxayo avatar Oct 30 '22 02:10 tuxayo

request: rename the issue "Captions don't work on popular instances" or something like that so people can more simply find it. And it's not an enhancement, it's a bug.

tuxayo avatar Oct 30 '22 02:10 tuxayo

How does newpipe does it? Is it because it does it directly so it's not rate limited at the expense of a risk of user tracking?

Whatever how newpipe does it, newpipe send the request from the IP address of the user so there no rate limit applied as a single user will never do as many requests as a Invidious instance.

unixfox avatar Oct 30 '22 07:10 unixfox

@rottenwheel syeopite seems to have solved the issue. They created a PR that is now merged.

RadoslavL avatar Sep 20 '23 09:09 RadoslavL

The only thing that's left to do is to document the fix. Instances will have to enable the use_innertube_for_captions option within the config to bring back caption capabilities.

syeopite avatar Sep 20 '23 15:09 syeopite