syedsaroshfarrukhdot
syedsaroshfarrukhdot
**Proposal** https://github.com/Expensify/App/blob/8e07c62fb9780c627106f45eb72614466a850f27/src/pages/home/report/ReportActionCompose.js#L595 This issue is caused by _.size(this.props.reportActions) === 1 in autofocus props of Composer when this.props.reportActions === 1 is true it focuses in the input field to fix the...
As mentioned by @christianwen _.size(this.props.reportActions) === 1 will cause a regression because that code is there so that when a user enters a new chat, the keyboard will be focused...
After testing `this.props.reportActions` i figured out it is nothing to do with `this.props.reportActions` it return always correct value the issue lies with autofocus props of the composer which if `true`,...
**Proposal** If we need to add Vertical Scroll Bar In Manage Members We Need To Set showsVerticalScrollIndicator={true} in FlatList https://github.com/Expensify/App/blob/151ec1ad3355cfa162ad490030f19a7134bbc076/src/pages/workspace/WorkspaceMembersPage.js#L315 After Fix :- https://user-images.githubusercontent.com/81307212/199288734-f8d29bd5-821b-41b7-9004-35308171c7cd.mov
@rushatgabhane Yes, we can do that by refactoring styling on WorkspaceMembersPage.js as it is due to padding=20 applied to parent view. https://github.com/Expensify/App/blob/main/src/pages/workspace/WorkspaceMembersPage.js ```diff - - + + - + this.toggleAllUsers()}...
@mountiny No, they don't influence design on mobile devices. It look same across the board. Desktop:- https://user-images.githubusercontent.com/81307212/200606043-01dc185c-e251-4e1f-ba8f-185fd9b5a9be.mov Web:- https://user-images.githubusercontent.com/81307212/200606101-1aa4960c-35c4-4590-b539-afadc84349ad.mov IOS:- https://user-images.githubusercontent.com/81307212/200606156-3363de63-cf0c-47e9-baf3-daf2c4120a72.mov mWEB Safari :- https://user-images.githubusercontent.com/81307212/200606222-ec8aff92-38bf-478f-adea-89920096d2fa.mov mWeb Chrome :- https://user-images.githubusercontent.com/81307212/200606341-bc87af33-2577-4eb7-a0d7-b94d5ebeeaf5.mov
@mountiny Thanks for assigning. Applied on Upwork. Will be raising a PR in next hours.
> @syedsaroshfarrukhdot I am sorry but in this case I will have to accept I made a mistake and overlooked the similarities. Given @0xmiroslav has proposed a solution which is...
[$250] Routing number field doesn't get auto focused after opening the page reported by @Puneet-here
**Proposal** The issue on android is due to transitions so we should wait for transitions to complete before focusing the input so we need to pass autoFocus and shouldDelayFocus props...
[$250] Routing number field doesn't get auto focused after opening the page reported by @Puneet-here
@rushatgabhane We can handle shouldDelayFocus on only on android Platform by introducing Platform.OS === 'android' just like below then it will delay focus only on android platform and fixing problem...