Daniel Lee
Daniel Lee
More help? What's "observable with its data collected"? I don't envision the Stan language being a PDE-specific language, so perhaps more descriptive names would be better? Things that would show...
I think `solve_pde` is good.
#1581 fixed a bit of this. The discussion has some more instances we need to fix.
While I'm looking at this, I'm going to clean up some of the code for readability. I'll leave some comments on the PR so you can see what I'm thinking...
@yizhang-yiz, for what it's worth, it's implemented really cleanly relative to the paper. The naming convention follows and is close. It looks right to me.
Looks like the "fix" I introduced causes it to have linking issues with multiple translation units. From Jenkins https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FMath/detail/PR-2619/11/pipeline/214: I believe this is real. I'll try to address it in...
I'm looking at the intent of the code and I think the optimization is too much effort relative to the difficulty in getting it working reliably across C++ versions. To...
Also, this would be dominated by the allocation of the `theta_m_single` and `theta_m_double` variables.
@andrjohns, thanks! I'm glad we could pull out the additional Eigen plug-in! That simplifies the logic and the burden on developers is significantly lower. I think it'll be worth it...
Moving to draft; it's still marked at "WIP." Please move it out of draft when you're ready.