Stewart X Addison

Results 1780 comments of Stewart X Addison

For some reason I'm getting failures at the end of the build when setting that value to `true`. It seems consistent and across all versions I've tried: ``` 10:37:00 C:\workspace\openjdk-build>rm...

It seems likely that this is being caused when the pipelines switch to the Eclipse system at https://github.com/adoptium/ci-jenkins-pipelines/blob/d33d46f39f7f3538abccf6520117c44530d85441/pipelines/build/common/openjdk_build_pipeline.groovy#L1652 Theory: It may be expecting it to still be running under a...

Noting that the `ENABLE_SIGN` option only takes effect for the final archive, not the signing of the individual build components on mac/windows. In order to make that get skipped when...

I had a call with @andrew-m-leonard today. We're going to look at a bit of a refactor of the build/buildScripts functions in [openjdk_build_pipelines.groovy](https://github.com/sxa/ci-jenkins-pipelines/blob/docker_windows_batch/pipelines/build/common/openjdk_build_pipeline.groovy) to split the 1400-line `buildScripts` function into...

I've started work in splitting up the `buildScripts` into three: - buildScriptsEclipseSigner - buildScriptsAssemble - buildScripts (The first, shared step) I've had to replicate some things between the `buildScripts` and...

@andrew-m-leonard A thought - since these changes will involve running part of it on the build machine, then switching over outside the main build context, and then switching back (starting...

> > @andrew-m-leonard A thought - since these changes will involve running part of it on the build machine, then switching over outside the main build context, and then switching...

> I've started work in splitting up the `buildScripts` into three: > I'm currently hitting this: `15:09:26 make[3]: *** No rule to make target '/cygdrive/c/progra~2/micros~1/2022/buildt~1/vc/redist/msvc/1436~1.325//x64/microsoft.vc143.crt/vcruntime140.dll', needed by '/cygdrive/c/workspace/openjdk-build/workspace/build/src/build/windows-x86_64-server-release/support/modules_libs/java.base/vcruntime140.dll'. Stop.` Looking...

After adding the `include` and `lib` directories from `Windows Kits` to the `ls` list for generating shortnames I've managed to get the assemble phase to completion. It's now tripping up...

First job with a successful sign_verification step: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk21u/job/windbld/709 There's a lot debug, and probably too much duplication in the new assembleBuild function at the moment which will now need to...