Mikołaj Świątek

Results 312 comments of Mikołaj Świątek

I haven't had much time recently to dig into this. If you want to try yourself, I'd try messing around with openssl, or just loading these certificates using the Go...

Blocked by https://github.com/open-telemetry/opentelemetry-operator/issues/4196.

You can set the instrumentation image in the CRD. Does that not solve your problem? The images we publish are tagged the same way as the underlying SDK.

I agree. We already support this extension, so we should support both ports.

Note that we have E2E tests checking both options - the CRD and the webhook - [here](https://github.com/open-telemetry/opentelemetry-operator/tree/main/tests/e2e-crd-validations/sidecar). These were originally done as E2E tests because we were already running them...

> Does this mean we cannot upgrade unless prometheus upgrades client-go to v0.33.2 or later? Yeah, we can't until Prometheus upgrades the dependency.

Now that https://github.com/prometheus/prometheus/pull/17200 is merged, we should be able to update prometheus-operator after we update to the next prometheus release.

This looks like an upstream issue to me: https://github.com/prometheus/prometheus/issues/17193. I'm not against adding a workaround to Target Allocator, but we need to be careful about what we actually do. Deviating...

@XuhuiSun95 what version of prometheus-operator and prometheus is this? In terms of service discovery, target allocator does exactly the same thing as Prometheus, so either the deduplication happens later, it...

@Horiodino since this doesn't happen with plain Prometheus, are you able to pinpoint where this deduplication happens in the Prometheus codebase?