Mikołaj Świątek

Results 312 comments of Mikołaj Świątek

@frzifus can you rebase this on main after #3393, and then we could finally merge?

> I think this makes sense... is there a way to write an e2e for this? Sure, you'd need to add a new test suite and run it with the...

> @swiatekm whats the best way to configure a k8s featuregate for a specific e2e test suite? > > Do we need to create a new e.g. `kind-1.30-native-sidecar.yaml` and register...

These should only be set if you have the mtls feature flag enabled - is that the case? Even in that case, setting them via command-line flags through `.Spec.Args` should...

I will go even further, and point out that Target Allocator isn't even necessarily Otel-specific. You could easily adapt it to horizontally scaling plain Prometheus, and there's been some efforts...

Also tagging @open-telemetry/operator-approvers @open-telemetry/operator-maintainers for visibility.

@nicolastakashi can we? Prometheus' service discovery discovers scrape targets, whereas here we just need a list of collector IDs. Sounds a bit overkill to me.

Assuming the `x-kubernetes-validations` field is ignored on K8s

@jbiers https://github.com/open-telemetry/opentelemetry-operator/pull/3580 looks good to me, that's exactly what we want. If you want to make similar changes for other CRDs, I'd prefer to review a separate PR for each...

@carsontham thank you for taking this up. To give a bit more detail, for collector metrics we just want to check if we can get any metrics at all -...