Matt Carey
Matt Carey
I think this looks good for the most part but I'm not a fan of removing the parameters in favor of a single hash for the API level methods. That's...
I know it's been a while since you've touched this (my apologies), I'm more than happy to make some changes myself to push this through if you've moved on from...
More than happy to update this @Dakurei can you join our server and give me your user ID so I can look into that for you? https://discord.gg/Mz2hm8Vw
Nevermind, I found your case and unbanned you from the Discord API server 🙂
I'm fine with size being a kwarg here, but for consistency's sake I wonder if we should keep it as an optional positional. I'd like some input
I would say `sticker_items` with a `stickers` alias. Since one is correct and the other is more natural
It would additionally be helpful to document any endpoints we currently cover and are now out of scope. An example would be some user only endpoints that may be hidden...
@Daniel-Worrall I'd like your input here. I think it's a fine change to make but one could argue for more explicit backtraces
``` [WARN : heartbeat @ 2021-01-05 18:18:09.175] Last heartbeat was not acked, so this is a zombie connection! Reconnecting [WARN : heartbeat @ 2021-01-05 18:18:50.430] Last heartbeat was not acked,...
We need to do a few more things for this change. Ideally we would kill the heartbeat loop on disconnect, and allow it to restart on HELLO, so we also...