Scott Walkinshaw

Results 174 comments of Scott Walkinshaw

I don't really understand how this fixes the issue though 🤔 The prop should exist: https://github.com/Shopify/storefront-api-examples/blob/ea24cff64152578a347695072cb41ba268c6662c/react-graphql-client/src/index.js#L18 Plus ` const client = this.props.client;` implies it *does* exist

Thanks @ryangrunest. Is it possible to just get the necessary changes in here? It's really hard to tell what the actual fix is vs other changes.

I can't push commits to his branch, so if you want to do a new PR then that would be helpful 👍

1.1 was a large refactor to use the newer graphql class-based API, so it's not too surprising that a few things fell through the cracks of the test coverage. Did...

This is actually a subset of https://github.com/xuorig/graphql-schema_comparator/issues/33. Ideally we'd capture every change for a new type?

Our use case is a GitHub bot which ran linting on PRs. We defined hooks based on each type of change (ie: `on_field_added`) which a lint rule would implement (similar...

Oh good point! Since the interface would return the resolved object type's name

Just to confirm, are expected and actual the two schemas you're comparing? I'd probably expect the diff between those to show no changes either. This might also be behaviour from...

Is `$ trellis cd SITE` literal? Meaning you'd type in `SITE`? (or `site`) If Sage were supported you'd type `trellis cd theme` or something?

🤦‍♂ of course sorry. Could it be more generic? * `$ trellis cd example.com` * `$ trellis cd example.com theme` And if you only have a single site: * `$...