graphql-schema_comparator icon indicating copy to clipboard operation
graphql-schema_comparator copied to clipboard

Changing an object to an interface isn't necessarily breaking

Open eapache opened this issue 3 years ago • 2 comments

"the type changed" is almost always a breaking change, except when going from an object to an interface with exactly the same set of fields (and implemented interfaces). It would be nice if schema_comparator recognized this case and didn't flag it as breaking.

eapache avatar Sep 30 '20 18:09 eapache

Perhaps this should be a dangerous change since clients will get different results if they're selecting __typename for this object/interface?

jturkel avatar Aug 04 '21 16:08 jturkel

Oh good point! Since the interface would return the resolved object type's name

swalkinshaw avatar Aug 04 '21 16:08 swalkinshaw