Matt Svoboda

Results 172 comments of Matt Svoboda

Not sure why the previous CI job failed. Pushed again to fix it.

> On the "one commit in PR". I too am used to that being the rule, so a while back I asked the development team about it and was told...

> The issue/PR I mumbled about cleaning up magic numbers was issue https://github.com/iina/iina/issues/3911. That issue also shows that for anything involving a NSSlider we have to account for changes Apple...

Take a look at the latest update. I put a lot of effort into reworking the OSC's layout calculations, and I think it's pretty slick. One of the key things...

One last bit of cleanup. Hopefully won't need any further changes. Also, since I was modifying the code affected by #4156 I went ahead and made sure that was fixed...

Something in the last couple of commits caused the floating OSC to be slightly too wide. Committed a fix...

@low-batt take a look at my latest commit. Assuming I understand #3863 correctly, it should now be fixed.

> I found a regression that needs to be fixed. The quick settings panel is now in front of the title bar as can been seen in this screen shot:...

> As for how odd that would look when the OSC is in the top layout, I'd have to see what that looks like. I would definitely prefer that over...

> Mumblings about reviewing and merging in preparation for a bug fix release have started. Stay tuned. Yay! Hopefully a lot can be merged 🤞🏻 > On the first screen...