Matt Svoboda

Disclaimer - I haven't run any tests here, and am just basing this on your above documentation and some casual browsing of the code, and intuition built from many years...

Oh yes, if `.terminateNow` is being used then all bets are off! I must confess I had come across #3591 before but I had mentally dismissed it, thinking it was...

I've added some inline comments to the PR, which shouldn't be interpreted as imperative statements as much as throwing out ideas. Indeed it does look like the complexity wasn't immediately...

> I don't see comments from you in PR https://github.com/iina/iina/pull/3952? Thanks for pointing that out - turns out I had made the comments but hadn't submitted the review. You should...

Also - there is another wrinkle which I think should be brought to attention. I had a question why `savePlaybackPosition()` was still explicitly called, because `MPVController.swift` contains this line which...

> The problem with failing to dynamically handle changes to the Resume last playback position preference must be solved in another way. Something in IINA needs to observe that IINA...

Excellent detective work!! It's great to hear that the original design isn't far off and there's less work to do. That is an interesting design decision by mpv, to limit...

UPDATE: I discovered there is a better way: `String.localizedStandardContains(String)`. I have updated the fix to use this method, which in addition to being case insensitive, is also diacritic insensitive (e.g.,...

This appears to be a regression via the code which was committed to fix #3692 (4abeb5b95113c9efe96f0503ff1540c633f44862). Storing the key in an unsorted dictionary did remove the duplicates, but caused the...

> The fix should follow mpv conventions for handling keys that have multiple different assignments in the input.conf file. I believe the file is treated as ordered and the first...