Sacha Viscaino

Results 7 comments of Sacha Viscaino

> @sviscaino Can you please squash the commits. Done

> Would this allow us to do json_extract functions like: > > ``` > JSON_EXTRACT('[{ "id": "my_id", "name": "my_name"}, { "id": "my_id2", "name": "my_name2"}, { "id": "my_id3", "name": "my_name3"}]', '$[*].id')...

> Do you know how Trino supports this ? Looks like Trino is not using jayway library. I looked at Jayway library and looks like no commits for the past...

> I discussed with few Presto folks. The recommendation is to remove the session property, default it to Presto, when the Presto parser fails, use the jayway. Sounds good (it...

> There are conflicts in this branch, can you please rebase and push. I need to run some verification tests (this will take couple of hours of my time) and...

> Can you add the benchmark that you said did not commit so we can be sure? Thanks! I put the link to the gist in the PR description. Do...

> Can you please add the Benchmark as well ? Ok, I committed the benchmark as well.